Deleting from Set while iterating

Блог пользователя luka25

Автор luka25, история, 10 лет назад, По-английски

I just tried to delete some members from set while iterating with this code:

while(*it<=b){ if(*it!=x){m[*it]=x;s.erase(it);} else it++; }

I found out the right one was this, but can't figure out why

while(*it<=b){ if(*it!=x){m[*it]=x;s.erase(it++);} else it++; }

could anybody explain why it++ instead of it please?

luka25
10 лет назад
5

Комментарии (5)

Написать комментарий?

zholnin

10 лет назад, скрыть # |

← Rev. 4 →

Because if you look into set documentation erase method you'll find the following:

Iterators, pointers and references referring to elements removed by the function are invalidated. All other iterators, pointers and references keep their validity.

so s.erase(it) invalides it.

s.erase(it++) works, because it++ returns copy of iterator. For example,++it wouldn't work.

→ Ответить

CountZero

10 лет назад, скрыть # ^ |

← Rev. 2 →

any code with postfix operators is undefined behavior waiting to happen. The only proper way to do it is
it = s.erase(it)

→ Ответить

luka25

10 лет назад, скрыть # ^ |

how it=s.erase(it)?I can't write that

→ Ответить

zholnin

10 лет назад, скрыть # ^ |

Are you sure?

All function parameters must be fully evaluated before function call — this is one of few rules you can be sure of in expression evaluation.

So it++ must be fully evaluated before function call. Which means that there should be two copies of it — one incremented, which becomes it going forward and one copy not incremented, which is provided to the function and afterwards deleted.

What can cause troubles?

Also it = s.erase(it) is only C++11.

→ Ответить