Passing object in c++ in a constructor

#	User	Rating
1	tourist	4009
2	jiangly	3821
3	Benq	3736
4	Radewoosh	3631
5	jqdai0815	3620
6	orzdevinwang	3529
7	ecnerwala	3446
8	Um_nik	3396
9	ksun48	3388
10	gamegame	3386

#	User	Contrib.
1	cry	164
1	maomao90	164
3	Um_nik	163
4	atcoder_official	161
5	-is-this-fft-	158
6	awoo	157
7	adamant	156
8	TheScrasse	154
8	nor	154
10	Dominater069	153

My earlier code which was giving error: complete implementation here: https://ideone.com/MuOmlS

Code giving compilation error

class Meeting
{
private:
    int start, end;
    Room room;

public:
    Meeting(int _start, int _end, Room _room)
    {
        start = _start;
        end = _end;
        room = _room;
    }
};
    //constructor was called
    // as calendar.push_back(Meeting(_start, _end, this));

.
.
.

This Code giving error as:

ERRORS


[ERROR]:
 error: field ‘room’ has incomplete type ‘Room’
     Room room;
           ^~~~
a.cpp: In constructor ‘Meeting::Meeting(int, int, Room)’:
a.cpp:23:40: error: ‘_room’ has incomplete type
     Meeting(int _start, int _end, Room _room)
                                        ^~~~~

a.cpp: In member function ‘bool Room::book(int, int)’:
a.cpp:72:54: error: no matching function for call to ‘Meeting::Meeting(int&, int&, Room*)’
         calendar.push_back(Meeting(_start, _end, this));
                                                      ^

correct code after referring this thread https://stackoverflow.com/questions/12466055/field-has-incomplete-type-error/12466219 i implemented and it worked but from this thread i couldn't able to understand why pointer object is doing which leads to removal of error?

complete implementation here: https://ideone.com/SSVnOU

Correct code ( doubt is don't know why working correctly)

class Meeting
{
private:
    int start, end;
    Room *room;

public:
    Meeting(int _start, int _end, Room *_room)
    {
        start = _start;
        end = _end;
        room = _room;
    }
    //constructor was called
    // as Meeting(new_start,new_end,this);
..

UPDATE:

After referring some blogs i came to know there is also an another way of handling this case

Different implemetation (correct)

Meeting::Meeting(int _start, int _end, Room room1):room(room1)
{
	start = _start;
	end = _end;
}
//constructor was called
// as Meeting(new_start,new_end,*this);

I Believe i am missing some concept of c++ language which i need to know to understand what's going on here. Please share your views regarding this.

Comments (1)

Show archived | Write comment?

codemastercpp

4 years ago, # |

The StackOverflow page you referred to had the answer. I'll just reiterate what was written there:

When you do forward declaration i.e only declare but not define, then the compiler just knows it'll exist, its definition is provided on link time. Now why it affects the way it did here: The compiler doesn't know the size of the object to allocate, since it's not defined, so we can only use a pointer which is always going to be the size of a memory address(4 bytes usually). We actually do this (forward declaration then using a pointer) in PIpml idiom too, if you've done that you can relate from there as well.

Hope it helps.

P.S: I'm not a Cpp expert(unlike my name suggests) so I might have said something wrong, but I think I explained the main question.

→ Reply

Sumanto's blog