Madiyar's blog

C++: Swap function
By Madiyar, history, 11 years ago, In English

Small brainteaser. Do you know that function below doesn't work in some cases.
Try to attack it. 

#include <iostream>

using namespace std;

void swap(int &a, int &b){ 
	a = a + b; 
	b = a - b; 
	a = a - b;
}
  • Vote: I like it
  • +55
  • Vote: I do not like it

Comments Comments (10)
| Write comment?
»
11 years ago, hide # |
← Rev. 2  
Vote: I like it +42 Vote: I do not like it

attempt in edit.

→ Reply
  • »
    »
    11 years ago, hide # ^ |
     
    Vote: I like it +37 Vote: I do not like it

    Yeap, it is true. But more interesting example is swap(a[i], a[j]), and accidentally i == j.

    → Reply
»
11 years ago, hide # |
 
Vote: I like it +37 Vote: I do not like it

do you mean the overflow, when a + b > 2^31 — 1

→ Reply
»
11 years ago, hide # |
← Rev. 2  
Vote: I like it +16 Vote: I do not like it

do not work if *a == *b

even it occurs overflow, it works well

→ Reply
»
11 years ago, hide # |
 
Vote: I like it +23 Vote: I do not like it

int a=12; swap(a,a);

→ Reply
»
11 years ago, hide # |
← Rev. 13  
Vote: I like it +1 Vote: I do not like it

best swap function without overflows :) 

void swap (int &a, int &b){ 
  if (&a != &b ) { 
	a ^= b; 
	b ^= a; 
	a ^= b;
      }
}
why downvotes ? :D epic
→ Reply
»
11 years ago, hide # |
 
Vote: I like it +11 Vote: I do not like it

that's why Mozilla created Rust. In this language any attempt to call swap(a, a) will lead to compile-time error. Prooflink: http://is.gd/m65CVw

→ Reply