Is finding rightmost set bit by this approach wrong.
int ans=xorsum,int rightmost=0;
while(ans){
int mask=1<<i;
if(ans&mask){
break;
}
ans=ans>>1;
i++;
}
rightmost=1<<i;
My code gave WA for some test cases when I used this code snippet to find rightmost set bit.It worked when I removed this with rightmost=xorsum&(-xorsum) can anyone please why the above got snippet may not work.
Why are you both left shifting the mask AND right shifting the number in which you're searching? "ans = ans >> 1" is the problem here; delete it and you should have no more problems.
You should remove
ans=ans>>1;, the i++ and 1<<i already move you to the left so there's no need to move ans to the right. ifans==48you get 4 when the answer is 16also I think this causes the snippet to miss odd powers of two entirely.